Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chat) add message reactions #15006

Open
wants to merge 70 commits into
base: master
Choose a base branch
from
Open

feat(chat) add message reactions #15006

wants to merge 70 commits into from
+731 −64

Conversation

he-patrick
Copy link
Contributor

  • add chat buttons to allow message reactions and other functionalities
  • render received reactions

@he-patrick
Add reaction button and kebab menu
46fd2cd
@he-patrick
Add emoji selector for ReactButton
b3cbe81
@he-patrick
Make buttons use Popover
512f931
@he-patrick
Add private message functionality
58a9e42
@he-patrick
Connect to lib-jitsi-meet
c315b48
@he-patrick
Update components
2b53a7b
@he-patrick
Add definitions and types
3c3c14f
@he-patrick
Reaction UI components pass in proper values
f62c904
@he-patrick
Handle reactions from lib-jitsi-meet
cf0bd37
@he-patrick
Place reactions within message
331e141
@he-patrick
Render three reactions in group and show timestamp on every message
0a39330
@he-patrick
Fix reaction id
a754161
@he-patrick
Fix eslint errors
d36f636
@he-patrick
Fix margin between reactions
51af82f
@he-patrick
Fix timestamp render location and reaction count colour
e3bf900
@he-patrick
feat(chat) use the original message ID for processing
1b1138f 
This is a prerequisite for operations that rely on previous messages, such as reactions.
@he-patrick
Add reaction button and kebab menu
171499a
@he-patrick
Add definitions and types
1b35cef
@he-patrick
Handle reactions from lib-jitsi-meet
fbfe141
@he-patrick
Fix reaction id
c2ee906
@he-patrick
Fix eslint errors
665f008
@he-patrick
Fix conflict errors
b2956e7
@he-patrick
Add canReact back
6f323b2
@he-patrick
Type errors
76918f4
@he-patrick
Fix linting issues
efb4488
@he-patrick
Fix reaction button and rendering issues
f2fb614
@he-patrick
Prevent duplicate reactions
b8d9e1a
@he-patrick
Revert "feat(deps) replace lodash with lodash-es"
ac80843 
This reverts commit 0d3feea.
@he-patrick
Revert accidental revert
dd5f585
@he-patrick
Merge branch 'jitsi:master' into master
da6ae54
@he-patrick he-patrick marked this pull request as ready for review September 3, 2024 03:09
mihhu
mihhu reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@mihhu mihhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaaalmost done, I left some comments 🙌

There's this thing I noticed when you were doing the demo too, did you have the chance to investigate it?
Pasted Graphic 1

react/features/chat/reducer.ts Outdated Show resolved Hide resolved
react/features/chat/components/web/KebabMenu.tsx Outdated Show resolved Hide resolved
react/features/chat/components/web/ChatMessage.tsx Outdated Show resolved Hide resolved
react/features/chat/components/web/ChatMessage.tsx Show resolved Hide resolved
react/features/chat/components/web/ChatMessage.tsx Outdated Show resolved Hide resolved
saghul
saghul requested changes Sep 5, 2024
View reviewed changes
react/features/chat/components/web/KebabMenu.tsx Outdated Show resolved Hide resolved
react/features/chat/components/web/KebabMenu.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihhu mihhu mihhu left review comments

@saghul saghul Awaiting requested review from saghul

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@he-patrick @jitsi-jenkins @mihhu @saghul