Merge pull request #36 from jfcarr-astronomy/release1/cleanup-prep

1) Removed unused documentation comments, 2) converted string values …
jfcarr · Dec 17, 2020 · 799179a · 799179a
2 parents c2f8d19 + b0186c3
commit 799179a
Show file tree

Hide file tree

Showing 13 changed files with 62 additions and 1,063 deletions.
diff --git a/PALib.Tests/PACoordinates.cs b/PALib.Tests/PACoordinates.cs
@@ -81,7 +81,7 @@ public void GalacticCoordinateToEquatorialCoordinate()
 		[Fact]
 		public void AngleBetweenTwoObjects()
 		{
-			Assert.Equal((23, 40, 25.86), _paCoordinates.AngleBetweenTwoObjects(5, 13, 31.7, -8, 13, 30, 6, 44, 13.4, -16, 41, 11, "H"));
+			Assert.Equal((23, 40, 25.86), _paCoordinates.AngleBetweenTwoObjects(5, 13, 31.7, -8, 13, 30, 6, 44, 13.4, -16, 41, 11, PAAngleMeasure.Hours));
 		}
 
 		[Fact]
@@ -113,13 +113,13 @@ public void CorrectForAberration()
 		[Fact]
 		public void AtmosphericRefraction()
 		{
-			Assert.Equal((23, 13, 44.74, 40, 19, 45.76), _paCoordinates.AtmosphericRefraction(23, 14, 0, 40, 10, 0, "TRUE", 0.17, 51.2036110, 0, 0, 23, 3, 1987, 1, 1, 24, 1012, 21.7));
+			Assert.Equal((23, 13, 44.74, 40, 19, 45.76), _paCoordinates.AtmosphericRefraction(23, 14, 0, 40, 10, 0, PACoordinateType.True, 0.17, 51.2036110, 0, 0, 23, 3, 1987, 1, 1, 24, 1012, 21.7));
 		}
 
 		[Fact]
 		public void CorrectionsForGeocentricParallax()
 		{
-			var result = _paCoordinates.CorrectionsForGeocentricParallax(22, 35, 19, -7, 41, 13, "TRUE", 1.019167, -100, 50, 60, 0, -6, 26, 2, 1979, 10, 45, 0);
+			var result = _paCoordinates.CorrectionsForGeocentricParallax(22, 35, 19, -7, 41, 13, PACoordinateType.True, 1.019167, -100, 50, 60, 0, -6, 26, 2, 1979, 10, 45, 0);
 
 			Assert.Equal((22, 36, 43.22, -8, 32, 17.4), result);
 		}

diff --git a/PALib.Tests/PADateTime.cs b/PALib.Tests/PADateTime.cs
@@ -62,7 +62,7 @@ public void UniversalTimeToGreenwichSiderealTime()
 		[Fact]
 		public void GreenwichSiderealTimeToUniversalTime()
 		{
-			Assert.Equal((14, 36, 51.67, "OK"), _paDateTime.GreenwichSiderealTimeToUniversalTime(4, 40, 5.23, 22, 4, 1980));
+			Assert.Equal((14, 36, 51.67, PAWarningFlag.OK), _paDateTime.GreenwichSiderealTimeToUniversalTime(4, 40, 5.23, 22, 4, 1980));
 		}
 
 		[Fact]

diff --git a/PALib/PABinary.cs b/PALib/PABinary.cs
@@ -9,11 +9,6 @@ public class PABinary
 		/// <summary>
 		/// Calculate orbital data for binary star.
 		/// </summary>
-		/// <param name="positionAngleDeg"></param>
-		/// <param name="greenwichDateDay"></param>
-		/// <param name="greenwichDateMonth"></param>
-		/// <param name="greenwichDateYear"></param>
-		/// <param name="binaryName"></param>
 		/// <returns>
 		/// <para>positionAngleDeg -- Position angle (degrees)</para>
 		/// <para>separationArcsec -- Separation of binary members (arcseconds)</para>

diff --git a/PALib/PAComet.cs b/PALib/PAComet.cs
@@ -9,15 +9,6 @@ public class PAComet
 		/// <summary>
 		/// Calculate position of an elliptical comet.
 		/// </summary>
-		/// <param name="lctHour"></param>
-		/// <param name="lctMin"></param>
-		/// <param name="lctSec"></param>
-		/// <param name="isDaylightSaving"></param>
-		/// <param name="zoneCorrectionHours"></param>
-		/// <param name="localDateDay"></param>
-		/// <param name="localDateMonth"></param>
-		/// <param name="localDateYear"></param>
-		/// <param name="cometName"></param>
 		/// <returns>
 		/// cometRAHour -- Right ascension of comet (hour part)
 		/// cometRAMin -- Right ascension of comet (minutes part)
@@ -76,15 +67,6 @@ public class PAComet
 		/// <summary>
 		/// Calculate position of a parabolic comet.
 		/// </summary>
-		/// <param name="lctHour"></param>
-		/// <param name="lctMin"></param>
-		/// <param name="lctSec"></param>
-		/// <param name="isDaylightSaving"></param>
-		/// <param name="zoneCorrectionHours"></param>
-		/// <param name="localDateDay"></param>
-		/// <param name="localDateMonth"></param>
-		/// <param name="localDateYear"></param>
-		/// <param name="cometName"></param>
 		/// <returns>
 		/// cometRAHour -- Right ascension of comet (hour part)
 		/// cometRAMin -- Right ascension of comet (minutes part)
@@ -103,8 +85,6 @@ public class PAComet
 			var greenwichDateMonth = PAMacros.LocalCivilTimeGreenwichMonth(lctHour, lctMin, lctSec, daylightSaving, zoneCorrectionHours, localDateDay, localDateMonth, localDateYear);
 			var greenwichDateYear = PAMacros.LocalCivilTimeGreenwichYear(lctHour, lctMin, lctSec, daylightSaving, zoneCorrectionHours, localDateDay, localDateMonth, localDateYear);
 
-			// var _utHours = PAMacros.LocalCivilTimeToUniversalTime(lctHour, lctMin, lctSec, daylightSaving, zoneCorrectionHours, localDateDay, localDateMonth, localDateYear);
-
 			var cometInfo = CometInfoParabolic.GetCometParabolicInfo(cometName);
 
 			var perihelionEpochDay = cometInfo.EpochPeriDay;
@@ -115,7 +95,6 @@ public class PAComet
 			var perihelionDeg = cometInfo.ArgPeri;
 			var nodeDeg = cometInfo.Node;
 
-			// let(comet_long_deg, comet_lat_deg, comet_dist_au) = 
 			var cometLongLatDist = PAMacros.PCometLongLatDist(lctHour, lctMin, lctSec, daylightSaving, zoneCorrectionHours, localDateDay, localDateMonth, localDateYear, perihelionEpochDay, perihelionEpochMonth, perihelionEpochYear, qAU, inclinationDeg, perihelionDeg, nodeDeg);
 
 			var cometRAHours = PAMacros.DecimalDegreesToDegreeHours(PAMacros.EcRA(cometLongLatDist.cometLongDeg, 0, 0, cometLongLatDist.cometLatDeg, 0, 0, greenwichDateDay, greenwichDateMonth, greenwichDateYear));