Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to login page in case token is expired instead of showing an error page #395

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

eva-mueller-coremedia
Copy link
Contributor

@eva-mueller-coremedia eva-mueller-coremedia commented Sep 12, 2024

Instead of showing an error page, the user should be redirected to the login page.

Proposal to solve: #396

Testing done

I have tested this with 4.340.ve70636c6590e and by setting the following

(Cognito) Refresh Configuration:

Refresh token expiration: 60 minutes
Access token expiration: 10 minutes
ID token expiration: 10 minutes

After 60 minutes, I got redirected to the login page instead of getting presented an error page.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Instead of showing an error page
@eva-mueller-coremedia
Copy link
Contributor Author

There are a lot of test failures. I will check them

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.72%. Comparing base (a5a97f8) to head (89afbcf).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
...va/org/jenkinsci/plugins/oic/OicSecurityRealm.java 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #395      +/-   ##
============================================
+ Coverage     71.88%   72.72%   +0.84%     
- Complexity      239      245       +6     
============================================
  Files            12       12              
  Lines          1010     1023      +13     
  Branches        145      148       +3     
============================================
+ Hits            726      744      +18     
+ Misses          206      199       -7     
- Partials         78       80       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants