Bump min supported Python to 3.10

[janosh]

start testing all make_assets scripts in GitHub Actions in 5b216f1 and so closes #164

[DanielYang59]

Perhaps we should also add a py.typed marker to include type information into the package?

Package maintainers who wish to support type checking of their code MUST add a marker file named py.typed to their package supporting typing. This marker applies recursively: if a top-level package includes it, all its sub-packages MUST support type checking as well. To have this file installed with the package, maintainers can use existing packaging options such as package_data in distutils, shown below.

[janosh]

Perhaps we should also add a py.typed marker to include type information into the package?

sure thing, please do! 👍

[janosh]

i'll make a new release after this PR to test it in production right away

[DanielYang59]

I was wondering why ffonons cannot be installed in CI, but encountered another issue locally. Do I need to install some additional packages beyond those listed in make-assets? Looks like ffonons requires data/phonon-db/map-mp-id-togo-id.csv

(venv) yang@Yang-MacBook make_assets % python3 phonons.py 
Traceback (most recent call last):
  File "/Users/yang/developer/pymatviz/examples/make_assets/phonons.py", line 29, in <module>
    docs[key] = json.loads(file.read(), cls=MontyDecoder)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.12.5/Frameworks/Python.framework/Versions/3.12/lib/python3.12/json/__init__.py", line 359, in loads
    return cls(**kw).decode(s)
           ^^^^^^^^^^^^^^^^^^^
  File "/Users/yang/developer/pymatviz/venv/lib/python3.12/site-packages/monty/json.py", line 875, in decode
    return self.process_decoded(d)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/yang/developer/pymatviz/venv/lib/python3.12/site-packages/monty/json.py", line 785, in process_decoded
    mod = __import__(modname, globals(), locals(), [classname], 0)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/yang/developer/pymatviz/venv/lib/python3.12/site-packages/ffonons/dbs/phonondb.py", line 39, in <module>
    mp_to_togo_id = pd.read_csv(id_map_path, index_col=0)[togo_id_key].to_dict()
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/yang/developer/pymatviz/venv/lib/python3.12/site-packages/pandas/io/parsers/readers.py", line 1026, in read_csv
    return _read(filepath_or_buffer, kwds)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/yang/developer/pymatviz/venv/lib/python3.12/site-packages/pandas/io/parsers/readers.py", line 620, in _read
    parser = TextFileReader(filepath_or_buffer, **kwds)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/yang/developer/pymatviz/venv/lib/python3.12/site-packages/pandas/io/parsers/readers.py", line 1620, in __init__
    self._engine = self._make_engine(f, self.engine)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/yang/developer/pymatviz/venv/lib/python3.12/site-packages/pandas/io/parsers/readers.py", line 1880, in _make_engine
    self.handles = get_handle(
                   ^^^^^^^^^^^
  File "/Users/yang/developer/pymatviz/venv/lib/python3.12/site-packages/pandas/io/common.py", line 873, in get_handle
    handle = open(
             ^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/Users/yang/developer/pymatviz/venv/lib/python3.12/site-packages/data/phonon-db/map-mp-id-togo-id.csv'

[janosh]

Looks like ffonons requires data/phonon-db/map-mp-id-togo-id.csv

yeah, that's an issue with the ffonons package which is still very much WIP. will fix that in the next release.

[DanielYang59]

Thanks for the input. I would add a TODO tag there :)