Video length on page #4776
Open
Video length on page #4776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: syeopite <[email protected]>
syeopite
requested changes
Jul 7, 2024
assets/css/default.css
Outdated
Comment on lines
26
to
38
| .dark-theme .length-watch-page{ | ||
| position: relative; | ||
| background-color: #fff; | ||
| color: rgba(35, 35, 35, 1); | ||
| border-radius: 2px; | ||
| padding: 4px; | ||
| font-size: 20px; | ||
| right: 0.25em; | ||
| bottom: 0.25em; | ||
| margin-left: 10px; | ||
| margin-right: 10px; | ||
| } | ||
|
|
There was a problem hiding this comment.
You don't need to specify these twice! In CSS the styles will inherit from the first .length-watch-page selector
Comment on lines
+28
to
+29
| background-color: #fff; | ||
| color: rgba(35, 35, 35, 1); |
There was a problem hiding this comment.
You're going to have to specify these again under the @media (prefers-color-scheme: dark) media query unfortunately as to support automatic theming
SamantazFox
reviewed
Jul 17, 2024
src/invidious/helpers/utils.cr
Outdated
Comment on lines
16
to
24
| if length.days > 0 | ||
| length_abbreviated = "#{length.days} d #{length.hours} hr #{length.minutes} min" | ||
| elsif length.hours > 0 | ||
| length_abbreviated = "#{length.hours} h #{length.minutes} min" | ||
| elsif length.minutes > 0 | ||
| length_abbreviated = "#{length.minutes} min" | ||
| else | ||
| length_abbreviated = "#{length.seconds} seconds" | ||
| end |
There was a problem hiding this comment.
Please make these translatable! It's better for non-English-speaking users ^^
SamantazFox
reviewed
Jul 21, 2024
Comment on lines
-2
to
-5
| "Add to playlist": "Add to playlist", | ||
| "Add to playlist: ": "Add to playlist: ", | ||
| "Answer": "Answer", | ||
| "Search for videos": "Search for videos", |
There was a problem hiding this comment.
Please do not change the indentation level in this file!
It will break out translation tool (Weblate)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good evening. This PR addresses the adjustments requested on this other (closed) PR that I was working on: #4274