Fix ambient doc tests #15500
Merged
Fix ambient doc tests #15500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
needs-rebase
istio-testing
added
the
size/L
istio-testing
removed
the
needs-rebase
|
/retest Don't think you fixed authz-tcp sorry @bleggett |
I definitely didn't fix it, but I thought I had hacked around it, oh well. |
|
/test doc.test.profile-default |
|
Opened #15505 |
bleggett
reviewed
Jul 31, 2024
bleggett
approved these changes
Jul 31, 2024
Co-authored-by: Ben Leggett <[email protected]>
howardjohn
approved these changes
Jul 31, 2024
grrr, I remember seeing that Co-authored-by: Daniel Hawton <[email protected]>
grrr, I remember seeing that |
dhawton
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Extend waypoints with WebAssembly plugins" docs page had a flake where it would check for the
Deploymentcreated by aGatewayimmediately after the gateway was created. It also depended on tests from the Getting Started guide, which has bitten us at least once.I've refactored the tests to fix both problems, and updated the test docs to mention the
ambientprofile.Further work may include setting up some helper scripts for labelling a namespace as ambient and cleaning up afterwards, but lots of the sidecar tests embed
kubectlandistioctlas I have done here so we have precedent that we can iterate on later.Closes #15498.