Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Swarm.RelayService.InfiniteLimits #9662

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lidel
Copy link
Member

@lidel lidel commented Feb 22, 2023

This PR needs #9656 to land first.

Context

Allowing users to switch from additional v1 relays to built-in v2 in Kubo.

The idea here is to expose libp2p/go-libp2p#2125 as an experimental, opt-in configuration option,
for running an unlimited relay in controlled environments (when relay and clients are managed by the same entity).

We want to fix/update tutorial from ipfs/ipfs-docs#1459. If we can remove the need for asking people to run a separate libp2p-relay-daemon v1), and only run Kubo, that it is a big win and reduction in complexity and DX/UX win.

TODO

cc @2color @TheDiscordian for visibility

@@ -67,7 +67,7 @@ require (
github.com/jbenet/go-temp-err-catcher v0.1.0
github.com/jbenet/goprocess v0.1.4
github.com/libp2p/go-doh-resolver v0.4.0
github.com/libp2p/go-libp2p v0.25.1
github.com/libp2p/go-libp2p v0.25.2-0.20230222220431-c03190e1ca4f
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ switch to release after #9656 lands.

Comment on lines +97 to +99
// InfiniteLimits effectively removes all limits. Enabling this option also
// doesn't apply any filter for which protocols can be used, allowing for
// expensive things like bitswap over a relayed connection.
Copy link
Member Author

@lidel lidel Feb 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 need to confirm bitswap works over a static v2 relay when we run with infinite limit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🔎 In Review
Development

Successfully merging this pull request may close these issues.

2 participants