Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move form toggles from bases/advanced to firewalls #8303

Merged
merged 8 commits into from
Sep 18, 2024

Conversation

satkunas
Copy link
Contributor

@satkunas satkunas commented Sep 12, 2024

Description

Moved from advanced configuration sso_on_dhcp, sso_on_reevaluate and sso_on_accounting directly in the firewall_sso configuration.

Impacts

Firewall SSO

Delete branch after merge

YES

Checklist

  • Document the feature
  • Add OpenAPI specification
  • Add unit tests
  • Add acceptance tests (TestLink)

NEWS file entries

Enhancements

  • SSO Action are now defined per firewall sso

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ fdurand
✅ satkunas
❌ Darren+Satkunas


Darren+Satkunas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@fdurand
Copy link
Member

fdurand commented Sep 17, 2024

Missing the upgrade script

@satkunas satkunas merged commit 4355b52 into devel Sep 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants