-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mobile): Add Partner Sharing Avatars to Timeline and Info Cards #12089
Open
x24git
wants to merge
6
commits into
immich-app:main
Choose a base branch
from
x24git:feat/shared-user-icons
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x24git
changed the title
feat(mobile) Add Partner Sharing Avatars to Timeline and Info Cards
feat(mobile): Add Partner Sharing Avatars to Timeline and Info Cards
Aug 27, 2024
I am working on implementing a similar feature set on the web app to ensure consistent experience |
Implements |
x24git
force-pushed
the
feat/shared-user-icons
branch
from
September 6, 2024 23:02
43f5361
to
cfa784f
Compare
Cleaned up commit history and rebased to main, resolving merge conflicts. |
PR #12413 implements the same feature set on web. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Feature adds user avatars to the timeline for both partner sharing, and shared albums. The avatar uses the user's avatar image (if one is set) or the server's information is used to make an avatar using the user's assigned color and first letter of their name.
(In the screenshot below, the partner's icon is an Orange 'T')
This is an optional configuration that adds a new setting in the Photo Grid section of the settings.
Additionally, storage information is now shown in the image details card. For partner sharing it will show which partner it belongs to. For other images, it provides a text description and existing storage icons if the photo is local, remote, or merged (backed up). This can be useful if the storage icons are hidden.