Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small fix for pigeon customization: #195

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

small fix for pigeon customization: #195

wants to merge 1 commit into from

Conversation

yaki-bcit
Copy link
Collaborator

  • set selectedPigeon to the updated value from DB instead of null inside updateSelectedPigeon

small fix for pigeon customization:
c068a38 
- set selectedPigeon to the updated value from DB instead of null inside updateSelectedPigeon
@yaki-bcit yaki-bcit requested a review from iliaamiri June 6, 2022 20:00
@iliaamiri
Copy link
Owner

iliaamiri commented Jun 6, 2022 •
edited
Loading

The currentPigeon property must be an instance of Pigeon model. The value that the playerEntity.getSelectedPigeon returns is not an instance of that model, but it is an entity object that comes straight out of the MySQL select query result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliaamiri iliaamiri Awaiting requested review from iliaamiri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaki-bcit @iliaamiri