Upload Images in Moments #1444
Merged
Upload Images in Moments #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this ready for review? :) |
bmwachajr
force-pushed
the
upload-picture-to-moment
branch
from
522d9bb
to
357db6e
Compare
|
@julianguyen yes it is ready for review. A couple of things to note.
|
|
We set the Cloudinary env variables in Heroku! |
julianguyen
previously approved these changes
May 27, 2019
|
@julianguyen yeah, all tests pass locally. It would be a good idea to set the environment variables for Cloudinary in CircleCI! Otherwise, once this PR is merged we shall always have these tests failing. |
bmwachajr
force-pushed
the
upload-picture-to-moment
branch
from
e1ba02f
to
b8a08c9
Compare
bmwachajr
force-pushed
the
upload-picture-to-moment
branch
4 times, most recently
from
e3a2df0
to
d2cf480
Compare
julianguyen
previously approved these changes
Jun 7, 2019
bmwachajr
force-pushed
the
upload-picture-to-moment
branch
from
d2cf480
to
73d7b68
Compare
julianguyen
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating a moment. it is valuable to upload an image to capture the moment/mood of the user.
More Details
More Details:
To do:
Corresponding Issue
Fixes #1480
Screenshots
Test Coverage
✅
🚫