Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing React Example of Marupay Package fixed #18 #38

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fixing React Example of Marupay Package fixed #18 #38

wants to merge 2 commits into from

Conversation

abdiaziiz-Arrale
Copy link

fixing React Example of Marupay Package fixed #18

@vercel Vercel
Copy link

vercel bot commented Dec 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marupay-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2023 8:38am

@iamshabell
Copy link
Owner

Hey @abdiaziiz-Arrale thanks for first contribution.

Regarding to this pull, I liked the way you did it. But I do have some suggestions:

  • Adding a new way that user could choose which payment he needs either edahab and waafi
  • Also I see only the purchase one, are you planning to add the credit one also. It dont have to be separate just add a new button that could initiate the credit method.
  • Are you planning an example that it could directly call the sdk without the need of any api.
  • And lastly, somehow the button un-clickable :)

Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example - React
2 participants
@abdiaziiz-Arrale @iamshabell