fix(Shell): Sometimes up-arrow wasn't showing history

hubotio · May 24, 2024 · 390d187 · 390d187
1 parent 82bbdbb
commit 390d187
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/adapters/Shell.mjs b/src/adapters/Shell.mjs
@@ -76,10 +76,8 @@ class Shell extends Adapter {
           break
       }
       if (input.length > 0) {
-        fs.appendFileSync(historyPath, `${input}\n`)
+        this.#rl.history.push(input)
       }
-      const history = fs.readFileSync(historyPath, 'utf-8').split('\n').reverse()
-      this.#rl.history = history
       let userId = process.env.HUBOT_SHELL_USER_ID || '1'
       if (userId.match(/A\d+z/)) {
         userId = parseInt(userId)
@@ -89,6 +87,9 @@ class Shell extends Adapter {
       await this.receive(new TextMessage(user, input, 'messageId'))
       this.#rl.prompt()
     })
+    this.#rl.on('history', async (history) => {
+      await fs.promises.writeFile(historyPath, history.reverse().join('\n'))
+    })
     try {
       this.#rl.prompt()
       this.emit('connected', this)