Added sleep prevention during file transfer #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grishka
requested changes
Oct 15, 2023
Polyfish0
force-pushed
the
master
branch
2 times, most recently
from
fa4d042
to
46ae7b1
Compare
sonique6784
reviewed
Nov 25, 2023
| @@ -329,6 +329,7 @@ class InboundNearbyConnection: NearbyConnection{ | |||
| private func acceptTransfer(){ | |||
| do{ | |||
| for (id, file) in transferredFiles{ | |||
| SleepManager.shared.disableSleep() | |||
There was a problem hiding this comment.
Could you move this outside of the for loop.
also you enableSleep when the connection is terminated, why not enableSleep after the for loop?
it is quite disconnect to have disable in this file and enable in the other file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was transferring a large file, my MacBook went into sleep mode and this caused the transfer to stop. The screen can still dim or turn off. But MacOS itself does not go into sleep mode.