Allow Redux Dev Tools Options #606
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,6 +44,7 @@ export function prepareReducer(allReducers, rootReducer) { | |||
| */ | |||
| export default function configureMakeStore( | |||
| { | |||
| devToolsOptions = {}, | |||
There was a problem hiding this comment.
Could you document this new option in the README.md for @gasket/redux? It'd also be good to put it in the TypeScript declarations.
There was a problem hiding this comment.
@rrex-godaddy is this PR still desirable? If so, could you please address the two items so we can get it merged and published?
|
Reached out to @rrex-godaddy on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to allow Devtools options to be passed to the gasket redux plugin
Changelog
Test Plan