Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Update CONTRIBUTING.md for the monorepo changes #4087

Open
wants to merge 1 commit into
base: v6
Choose a base branch
from

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Sep 12, 2024

#skip-changelog

@antonis
Copy link
Collaborator

antonis commented Sep 18, 2024

l: Adding a note on a minor issue I encountered. I think the yarn run-android and yarn run-ios on the Run the emulators sections should be changed to yarn android and yarn ios to match the scripts of the samples.
I'll be glad to open a separate PR for this but thought of adding a note on this related PR 1st.

@lucas-zimerman
Copy link
Collaborator

lucas-zimerman commented Sep 18, 2024

I like the idea of both samples and main SDK having the same script name for running the ios/android samples, although, I usually don't use those commands (only yarn start) since the yarn run-android does nothing for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants