3.9.0 (#791)

getsentry · Dec 7, 2016 · 2ed8093 · 2ed8093
1 parent 8bbd939
commit 2ed8093
Show file tree

Hide file tree

Showing 27 changed files with 121 additions and 53 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,14 @@
 # Changelog
 
+## 3.9.0
+* NEW: `breadcrumbCallback` and `setBreadcrumbCallback` for filtering/mutating breadcrumbs. See: https://github.com/getsentry/raven-js/pull/788
+* NEW: Can enable synthetic traces globally via `stacktrace: true` config option. See: https://github.com/getsentry/raven-js/pull/763
+* CHANGE: Can set user context via `config` under `user` key. See: https://github.com/getsentry/raven-js/pull/762
+* CHANGE: Unit and integration tests now run on PhantomJS 2. See: https://github.com/getsentry/raven-js/pull/777
+* BUGFIX: Fix mouse click breadcrumbs not captured in some scenarios. See: https://github.com/getsentry/raven-js/pull/766
+* BUGFIX: React Native plugin normalizes paths in stacktraces generated via `captureMessage`. See: https://github.com/getsentry/raven-js/pull/778
+* BUGFIX: Doesn't break when window is absent (e.g. inside web workers). See: https://github.com/getsentry/raven-js/pull/785
+
 ## 3.8.1
 * BUGFIX: Fix dangling comma affecting IE8. See: https://github.com/getsentry/raven-js/pull/769
 

diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "raven-js",
-  "version": "3.8.0",
+  "version": "3.9.0",
   "dependencies": {},
   "main": "dist/raven.js",
   "ignore": [

diff --git a/dist/plugins/angular.js b/dist/plugins/angular.js
@@ -1,4 +1,4 @@
-/*! Raven.js 3.8.0 (d78f15c) | github.com/getsentry/raven-js */
+/*! Raven.js 3.9.0 (8bbd939) | github.com/getsentry/raven-js */
 
 /*
  * Includes TraceKit

diff --git a/dist/plugins/angular.min.js b/dist/plugins/angular.min.js
diff --git a/dist/plugins/console.js b/dist/plugins/console.js
@@ -1,4 +1,4 @@
-/*! Raven.js 3.8.0 (d78f15c) | github.com/getsentry/raven-js */
+/*! Raven.js 3.9.0 (8bbd939) | github.com/getsentry/raven-js */
 
 /*
  * Includes TraceKit

diff --git a/dist/plugins/console.min.js b/dist/plugins/console.min.js
diff --git a/dist/plugins/ember.js b/dist/plugins/ember.js
@@ -1,4 +1,4 @@
-/*! Raven.js 3.8.0 (d78f15c) | github.com/getsentry/raven-js */
+/*! Raven.js 3.9.0 (8bbd939) | github.com/getsentry/raven-js */
 
 /*
  * Includes TraceKit

diff --git a/dist/plugins/ember.min.js b/dist/plugins/ember.min.js
diff --git a/dist/plugins/require.js b/dist/plugins/require.js
@@ -1,4 +1,4 @@
-/*! Raven.js 3.8.0 (d78f15c) | github.com/getsentry/raven-js */
+/*! Raven.js 3.9.0 (8bbd939) | github.com/getsentry/raven-js */
 
 /*
  * Includes TraceKit

diff --git a/dist/plugins/require.min.js b/dist/plugins/require.min.js
diff --git a/dist/plugins/vue.js b/dist/plugins/vue.js
@@ -1,4 +1,4 @@
-/*! Raven.js 3.8.0 (d78f15c) | github.com/getsentry/raven-js */
+/*! Raven.js 3.9.0 (8bbd939) | github.com/getsentry/raven-js */
 
 /*
  * Includes TraceKit

diff --git a/dist/plugins/vue.min.js b/dist/plugins/vue.min.js
diff --git a/dist/raven.js b/dist/raven.js
@@ -1,4 +1,4 @@
-/*! Raven.js 3.8.0 (d78f15c) | github.com/getsentry/raven-js */
+/*! Raven.js 3.9.0 (8bbd939) | github.com/getsentry/raven-js */
 
 /*
  * Includes TraceKit
@@ -91,6 +91,7 @@ module.exports = {
 };
 
 },{}],4:[function(_dereq_,module,exports){
+(function (global){
 /*global XDomainRequest:false, __DEV__:false*/
 'use strict';
 
@@ -107,8 +108,12 @@ function now() {
     return +new Date();
 }
 
-var _window = typeof window !== 'undefined' ? window : undefined;
-var _document = _window && _window.document;
+// This is to be defensive in environments where window does not exist (see https://github.com/getsentry/raven-js/pull/785)
+var _window = typeof window !== 'undefined' ? window
+            : typeof global !== 'undefined' ? global
+            : typeof self !== 'undefined' ? self
+            : {};
+var _document = _window.document;
 
 // First, check for JSON support
 // If there is no JSON, we no-op the core features of Raven
@@ -167,7 +172,7 @@ Raven.prototype = {
     // webpack (using a build step causes webpack #1617). Grunt verifies that
     // this value matches package.json during build.
     //   See: https://github.com/getsentry/raven-js/issues/465
-    VERSION: '3.8.0',
+    VERSION: '3.9.0',
 
     debug: false,
 
@@ -195,7 +200,7 @@ Raven.prototype = {
         if (options) {
             each(options, function(key, value){
                 // tags and extra are special and need to be put into context
-                if (key === 'tags' || key === 'extra') {
+                if (key === 'tags' || key === 'extra' || key === 'user') {
                     self._globalContext[key] = value;
                 } else {
                     globalOptions[key] = value;
@@ -221,7 +226,7 @@ Raven.prototype = {
             xhr: true,
             console: true,
             dom: true,
-            location: true,
+            location: true
         };
 
         var autoBreadcrumbs = globalOptions.autoBreadcrumbs;
@@ -456,11 +461,13 @@ Raven.prototype = {
             return;
         }
 
+        options = options || {};
+
         var data = objectMerge({
             message: msg + ''  // Make sure it's actually a string
         }, options);
 
-        if (options && options.stacktrace) {
+        if (this._globalOptions.stacktrace || (options && options.stacktrace)) {
             var ex;
             // create a stack trace from this point; just trim
             // off extra frames so they don't include this function call (or
@@ -500,6 +507,16 @@ Raven.prototype = {
             timestamp: now() / 1000
         }, obj);
 
+        if (isFunction(this._globalOptions.breadcrumbCallback)) {
+            var result = this._globalOptions.breadcrumbCallback(crumb);
+
+            if (isObject(result) && !isEmptyObject(result)) {
+                crumb = result;
+            } else if (result === false) {
+                return this;
+            }
+        }
+
         this._breadcrumbs.push(crumb);
         if (this._breadcrumbs.length > this._globalOptions.maxBreadcrumbs) {
             this._breadcrumbs.shift();
@@ -617,6 +634,22 @@ Raven.prototype = {
         return this;
     },
 
+    /*
+     * Set the breadcrumbCallback option
+     *
+     * @param {function} callback The callback to run which allows filtering
+     *                            or mutating breadcrumbs
+     * @return {Raven}
+     */
+    setBreadcrumbCallback: function(callback) {
+        var original = this._globalOptions.breadcrumbCallback;
+        this._globalOptions.breadcrumbCallback = isFunction(callback)
+          ? function (data) { return callback(data, original); }
+          : callback;
+
+        return this;
+    },
+
     /*
      * Set the shouldSendCallback option
      *
@@ -827,7 +860,6 @@ Raven.prototype = {
         // TODO: if somehow user switches keypress target before
         //       debounce timeout is triggered, we will only capture
         //       a single breadcrumb from the FIRST target (acceptable?)
-
         return function (evt) {
             var target = evt.target,
                 tagName = target && target.tagName;
@@ -846,7 +878,7 @@ Raven.prototype = {
             }
             clearTimeout(timeout);
             self._keypressTimeout = setTimeout(function () {
-               self._keypressTimeout = null;
+                self._keypressTimeout = null;
             }, debounceDuration);
         };
     },
@@ -932,13 +964,24 @@ Raven.prototype = {
 
                         // More breadcrumb DOM capture ... done here and not in `_instrumentBreadcrumbs`
                         // so that we don't have more than one wrapper function
-                        var before;
+                        var before,
+                            clickHandler,
+                            keypressHandler;
+
                         if (autoBreadcrumbs && autoBreadcrumbs.dom && (global === 'EventTarget' || global === 'Node')) {
-                            if (evtName === 'click'){
-                                before = self._breadcrumbEventHandler(evtName);
-                            } else if (evtName === 'keypress') {
-                                before = self._keypressEventHandler();
-                            }
+                            // NOTE: generating multiple handlers per addEventListener invocation, should
+                            //       revisit and verify we can just use one (almost certainly)
+                            clickHandler = self._breadcrumbEventHandler('click');
+                            keypressHandler = self._keypressEventHandler();
+                            before = function (evt) {
+                                // need to intercept every DOM event in `before` argument, in case that
+                                // same wrapped method is re-used for different events (e.g. mousemove THEN click)
+                                // see #724
+                                if (evt.type === 'click')
+                                    return clickHandler(evt);
+                                else if (evt.type === 'keypress')
+                                    return keypressHandler(evt);
+                            };
                         }
                         return orig.call(this, evtName, self.wrap(fn, undefined, before), capture, secure);
                     };
@@ -1849,7 +1892,9 @@ Raven.prototype.setReleaseContext = Raven.prototype.setRelease;
 
 module.exports = Raven;
 
+}).call(this,typeof global !== "undefined" ? global : typeof self !== "undefined" ? self : typeof window !== "undefined" ? window : {})
 },{"1":1,"2":2,"3":3,"6":6}],5:[function(_dereq_,module,exports){
+(function (global){
 /**
  * Enforces a single instance of the Raven client, and the
  * main entry point for Raven. If you are a consumer of the
@@ -1860,7 +1905,12 @@ module.exports = Raven;
 
 var RavenConstructor = _dereq_(4);
 
-var _Raven = window.Raven;
+// This is to be defensive in environments where window does not exist (see https://github.com/getsentry/raven-js/pull/785)
+var _window = typeof window !== 'undefined' ? window
+            : typeof global !== 'undefined' ? global
+            : typeof self !== 'undefined' ? self
+            : {};
+var _Raven = _window.Raven;
 
 var Raven = new RavenConstructor();
 
@@ -1871,15 +1921,17 @@ var Raven = new RavenConstructor();
  * @return {Raven}
  */
 Raven.noConflict = function () {
-	window.Raven = _Raven;
+	_window.Raven = _Raven;
 	return Raven;
 };
 
 Raven.afterLoad();
 
 module.exports = Raven;
 
+}).call(this,typeof global !== "undefined" ? global : typeof self !== "undefined" ? self : typeof window !== "undefined" ? window : {})
 },{"4":4}],6:[function(_dereq_,module,exports){
+(function (global){
 'use strict';
 
 /*
@@ -1892,6 +1944,12 @@ var TraceKit = {
     debug: false
 };
 
+// This is to be defensive in environments where window does not exist (see https://github.com/getsentry/raven-js/pull/785)
+var _window = typeof window !== 'undefined' ? window
+            : typeof global !== 'undefined' ? global
+            : typeof self !== 'undefined' ? self
+            : {};
+
 // global reference to slice
 var _slice = [].slice;
 var UNKNOWN_FUNCTION = '?';
@@ -2070,8 +2128,8 @@ TraceKit.report = (function reportModuleWrapper() {
         if (_onErrorHandlerInstalled) {
             return;
         }
-        _oldOnerrorHandler = window.onerror;
-        window.onerror = traceKitWindowOnError;
+        _oldOnerrorHandler = _window.onerror;
+        _window.onerror = traceKitWindowOnError;
         _onErrorHandlerInstalled = true;
     }
 
@@ -2080,7 +2138,7 @@ TraceKit.report = (function reportModuleWrapper() {
         if (!_onErrorHandlerInstalled) {
             return;
         }
-        window.onerror = _oldOnerrorHandler;
+        _window.onerror = _oldOnerrorHandler;
         _onErrorHandlerInstalled = false;
         _oldOnerrorHandler = undefined;
     }
@@ -2482,5 +2540,6 @@ TraceKit.computeStackTrace = (function computeStackTraceWrapper() {
 
 module.exports = TraceKit;
 
+}).call(this,typeof global !== "undefined" ? global : typeof self !== "undefined" ? self : typeof window !== "undefined" ? window : {})
 },{}]},{},[5])(5)
 });
diff --git a/dist/raven.min.js b/dist/raven.min.js
diff --git a/dist/raven.min.js.map b/dist/raven.min.js.map
diff --git a/dist/sri.json b/dist/sri.json
@@ -1,20 +1,20 @@
 {
   "@dist/raven.js": {
     "hashes": {
-      "sha256": "4miBSrBY0YRTMgqQ7tIKJ5bC1iJWSDJcg+lYca93DVI=",
-      "sha512": "ziKXaLU8oaGyZRk4MrdPLqejNAcAr+vvUg+OpMGrQ1tr6j2TK11OLn3RkawUOomzxCz6VgIBA7b3wLco9jmEeA=="
+      "sha256": "ihdEI9/hV9q/+yUm+WxgLgncmbFnuK9tr/lRnRgr60k=",
+      "sha512": "4WMClk7qzYHXT5/xR3X9RkpNs8dg/FIfbJ7RTythr9rXMRAVIDimD2X6NLEUdID+c7sJ3b6oOvsmf6oB0ORhwg=="
     },
     "type": null,
-    "integrity": "sha256-4miBSrBY0YRTMgqQ7tIKJ5bC1iJWSDJcg+lYca93DVI= sha512-ziKXaLU8oaGyZRk4MrdPLqejNAcAr+vvUg+OpMGrQ1tr6j2TK11OLn3RkawUOomzxCz6VgIBA7b3wLco9jmEeA==",
+    "integrity": "sha256-ihdEI9/hV9q/+yUm+WxgLgncmbFnuK9tr/lRnRgr60k= sha512-4WMClk7qzYHXT5/xR3X9RkpNs8dg/FIfbJ7RTythr9rXMRAVIDimD2X6NLEUdID+c7sJ3b6oOvsmf6oB0ORhwg==",
     "path": "dist/raven.js"
   },
   "@dist/raven.min.js": {
     "hashes": {
-      "sha256": "qP1Ly+j8g4xsul2MZaCZv6byFgLvRHuiI/bct6JluOw=",
-      "sha512": "EQGo6LBb2E0sCr7jfkQN7d3wzdFcWWD8b0FxP/Dahoa827Wk9KpsxSsA6IS8B+RNGkUHLaOP5G21p+EA3odqBA=="
+      "sha256": "Iwsp4zEtQhPhOFbMNyTevyNpy7XTm8qUPteSJyopHDM=",
+      "sha512": "lL3X3M9f+DKT/mcKDJWixbXdXhVlYGWxy5DuPYyV6LrD8KNWQJ6ahpvTK3IyosXEAj3x+PWQ1DnFbKyGbIGdBw=="
     },
     "type": null,
-    "integrity": "sha256-qP1Ly+j8g4xsul2MZaCZv6byFgLvRHuiI/bct6JluOw= sha512-EQGo6LBb2E0sCr7jfkQN7d3wzdFcWWD8b0FxP/Dahoa827Wk9KpsxSsA6IS8B+RNGkUHLaOP5G21p+EA3odqBA==",
+    "integrity": "sha256-Iwsp4zEtQhPhOFbMNyTevyNpy7XTm8qUPteSJyopHDM= sha512-lL3X3M9f+DKT/mcKDJWixbXdXhVlYGWxy5DuPYyV6LrD8KNWQJ6ahpvTK3IyosXEAj3x+PWQ1DnFbKyGbIGdBw==",
     "path": "dist/raven.min.js"
   }
 }