Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design improvements #127

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

kocsmy
Copy link
Contributor

@kocsmy kocsmy commented Oct 19, 2018

Closes #124 .

@kocsmy kocsmy changed the title Design improvements for #124 Design improvements Oct 19, 2018
@kocsmy
Copy link
Contributor Author

kocsmy commented Oct 19, 2018

image

@kocsmy
Copy link
Contributor Author

kocsmy commented Oct 19, 2018

image

Add "Did you find this useful?" section to the bottom of the kb-articles.

@arikfr
Copy link
Member

arikfr commented Oct 21, 2018

  1. I think two icons is enough, while it lowers the resolution it increases the chances of getting a feedback (because it requires less thinking). Also I think that more neutral emojis will work better -- 👍 👎 . For me something like "😍" means that this article solved all my problems and then more. :)
  2. How will it look like after the user submitted the feedback?
  3. Maybe have a single footer, where both edit button and feedback buttons are together?

@kocsmy
Copy link
Contributor Author

kocsmy commented Oct 21, 2018

image

The Edit on GitHub stands out more when it's on a new line. Both works for me though.

I'll add a Thank you message animation once it's submitted.

@arikfr
Copy link
Member

arikfr commented Oct 21, 2018

I like the last iteration. 👍

@kocsmy
Copy link
Contributor Author

kocsmy commented Oct 21, 2018

How about this as a final version (I made the button color black instead here, hover is blue button, white text)?

image

@arikfr
Copy link
Member

arikfr commented Oct 22, 2018

Looks good.

@kocsmy
Copy link
Contributor Author

kocsmy commented Oct 23, 2018

This is the thank you message we show after you casted your vote:
image

The opacity here should be set to 1 once the vote has been casted:
<span class="wtu-thankyou" style="opacity: 0;">Thank you!</span>

FYI Edit on GitHub button is hidden on smaller screens.

@arikfr arikfr added the backlog label Dec 17, 2018
@susodapop
Copy link
Contributor

@arikfr This will need to be migrated to Gatsby I think.

@arikfr
Copy link
Member

arikfr commented Feb 3, 2019

@susodapop of course. It's on me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants