[File][xs]: normalize file name by trimming, replacing spaces with '-…

…' and lowercasing - refs datahubio/datahub-v2-pm#141

lib/index.js

@@ -235,10 +235,15 @@ const parsePath = (path_, basePath = null, format = null) => {
   }
 
   const extension = path.extname(fileName)
+  fileName = fileName.replace(extension, '')
+    .toLowerCase()
+    .trim()
+    .replace(/&/g, '-and-')
+    .replace(/[^a-z0-9-._]+/g, '-')
   const descriptor = {
     path: path_,
     pathType: isItUrl ? 'remote' : 'local',
-    name: fileName.replace(extension, ''),
+    name: fileName,
     format: format ? format : extension.slice(1).toLowerCase()
   }
 

test/fixtures/some file.name.ext

@@ -0,0 +1 @@
+Content

test/index.test.js

@@ -182,7 +182,7 @@ test('parsePath function with remote url without conventional filename', t => {
   const res = data.parsePath(path_)
   t.is(res.path, path_)
   t.is(res.pathType, 'remote')
-  t.is(res.name, 'NY.GDP.MKTP')
+  t.is(res.name, 'ny.gdp.mktp')
   t.is(res.format, 'csv')
   t.is(res.mediatype, undefined)
 })
@@ -331,6 +331,12 @@ test('File class for addSchema method', async t => {
   t.deepEqual(headers, ['number', 'string', 'boolean'])
 })
 
+test('File name has spaces and dots', async t => {
+  let path_ = 'test/fixtures/some file.name.ext'
+  let file = data.File.load(path_)
+  t.is(file.descriptor.name, 'some-file.name')
+})
+
 // ====================================
 // Dataset class
 // ====================================