Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info for scarb packages uploads #2460

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add info for scarb packages uploads #2460

wants to merge 1 commit into from
+17 −1

Conversation

THenry14
Copy link
Contributor

@THenry14 THenry14 commented Sep 11, 2024 •
edited
Loading

Related to #2344

This PR is a part of the stack:
--> Add missing info recommended for package uploads (This PR)
-- Add github action workflow for automatic registry uploads during release (#2461)

Introduced changes

  • Adds readmes and links to respective Scarb.tomls, so to view this metadata on the registry and supress scarb warnings
  • Bump snforge_scarb_plugin version to 0.2.0, to properly reflect its version in regards to the registry. From now on all changes made to this crate should be concluded with version bump

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@THenry14 THenry14 mentioned this pull request Sep 11, 2024
Draft
5 tasks
@maciektr maciektr mentioned this pull request Sep 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksew1 ksew1 Awaiting requested review from ksew1 ksew1 will be requested when the pull request is marked ready for review ksew1 is a code owner

@integraledelebesgue integraledelebesgue Awaiting requested review from integraledelebesgue integraledelebesgue will be requested when the pull request is marked ready for review integraledelebesgue is a code owner

@cptartur cptartur Awaiting requested review from cptartur cptartur will be requested when the pull request is marked ready for review cptartur is a code owner

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski will be requested when the pull request is marked ready for review ddoktorski is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@THenry14