Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing loop over block columns of C #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

angsch
Copy link

@angsch angsch commented Jul 29, 2023

The block column width of C is defined by #define nb 1000 and used to allocate the buffers, but otherwise nb is unused.
As a result, if the m-by-n matrix C has n > nb, the code encounters a segmentation fault. This commit fixes this issue by

  • adding the missing loop over the block columns of C, and
  • adjusting the default leading dimensions to whatever the row count is.

If the column count of C exceeds 1000, the code
encounters a segmentation fault. The block size
is defined #define nb 1000 and used to allocate
the buffers. However, n instead of nb is
passed.

* add the missing loop over block columns of C
* adjust the leading dimensions to select
  whatever the row count is
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant