Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use intrinsics for all sifive_x280 kernels #822

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

myeh01
Copy link

@myeh01 myeh01 commented Aug 1, 2024

To address a bug encountered in #805, this PR converts all kernels in the sifive_x280 configuration written in inline assembly to intrinsics.

Copy link
Contributor

@Aaron-Hutchinson Aaron-Hutchinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing all of these conversions, @myeh01!

kernels/sifive_x280/riscv_overloaded_intrinsics.h Outdated Show resolved Hide resolved
@leekillough
Copy link
Collaborator

If you check the CI/CD build, you see one compiler error.

kernels/sifive_x280/1/bli_invscalv_sifive_x280_intr/./bli_invscalv_sifive_x280_intr_complex.c:68:43: fatal error: call to undeclared function '__riscv_vundefined_f32m4x2'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]

@leekillough
Copy link
Collaborator

Integer types (size_t, guint_t, int) are mixed; some occurrences do not have a type conversion. This would be problem if potentially unsafe integer conversions were disallowed. However, I think that this is an issue throughout BLIS.

@myeh01 myeh01 changed the title Use intrinsics for all sifive_x280 level 1, 1f, 1m kernels Use intrinsics for all sifive_x280 kernels Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants