Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add complex return detection for nvfortran #765

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jeffhammond
Copy link
Member

historically, PGI->NVHPC Fortran has used the Intel convention. this is true on x86_64 and ppc64le, and has been true on aarch64. however, starting with the 23.9 release, on the aarch64 platform, nvfortran will switch to the gfortran convention.

this patch adds the appropriate logic to configure. this patch has not been tested at all. i am relying on CI for that.

sort of related to #433

jeffhammond and others added 3 commits August 8, 2023 17:30
historically, PGI->NVHPC Fortran has used the Intel convention.
this is true on x86_64 and ppc64le, and has been true on aarch64.
however, starting with the 23.9 release, on the aarch64 platform,
nvfortran will switch to the gfortran convention.

this patch adds the appropriate logic to configure.
this patch has not been tested at all.  i am relying on CI for that.

Signed-off-by: Jeff Hammond <[email protected]>
@fgvanzee
Copy link
Member

@jeffhammond Let me know when you feel good about calling this PR done, and I'll merge.

@jeffhammond
Copy link
Member Author

I need to test a few places and haven't had time but I'll let you know when it's validated everywhere relevant.

@devinamatthews
Copy link
Member

@jeffhammond any update on this?

@jeffhammond
Copy link
Member Author

thanks for the reminder. i do not remember what i did so i'll have to try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants