Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isNewMethod to deal with partially created methods #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

StephanEggermont
Copy link

If selector is still nil, the method has not been successfully compiled yet

@syrel
Copy link
Member

syrel commented Jun 4, 2021

@StephanEggermont Thanks for opening a pull request!
The more I look at the isNewMethod the less I like it.
There is already a nice method GtPharoMethodCoder>>#existsInTheSystem, let's use it instead and remove isNewMethod

@StephanEggermont
Copy link
Author

In buildRemoveMethodLabel: it was already noticed that the selector could be nil. I agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants