Let wl-copy treat passwords as sensitive #93
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good, thanks for bringing this up! Let's discuss the details when it has landed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wl-copy will (sometime) soon be able to differentiate when sensitive data is being copied, so that clipboard managers (like cliphist) can ignore this data downstream.
Keepass has been flagging passwords as sensitive by setting a mime type of "x-kde-passwordManagerHint" and this is how wl-clipboard will implement it.
This PR is a only a draft because the feature has not yet been merged: bugaevc/wl-clipboard#204 bugaevc/wl-clipboard#177
I am currently using those changes and it works well, the copied entries from rofi-rbw are not stored by my clipboard manager.
EDIT: if theres interest and the wl-clipboard PR gets merged, I can open the PR properly