feat(fastly_secretstore): implement resource and documentation #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccurdyc
approved these changes
Jun 9, 2023
mccurdyc
approved these changes
Jun 9, 2023
Integralist
commented
Jun 29, 2023
mccurdyc
approved these changes
Jun 29, 2023
|
Hi, glad to see this coming! We could really use this for our terraform deployment, are there any plans on when this will be merged and available? |
|
Thanks @jfctfl I'm just at this moment chasing up feedback on when I'm able to merge this PR and publish it into a new release. Unfortunately I don't have a timeline yet. Hopefully not too long. |
|
Awesome 🚀 |
Integralist
force-pushed
the
integralist/secret-store
branch
3 times, most recently
from
cd435f3
to
6404f7a
Compare
Integralist
force-pushed
the
integralist/secret-store
branch
from
6404f7a
to
31aee2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new
fastly_secretstoreresource andfastly_secretstoresdata source.✅ The full end-to-end integration test suite has been run and is passing successfully.