httpsession: prep work for supporting fetches other than next #48065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkarneges
commented
Sep 5, 2024
| @@ -1232,114 +1242,121 @@ class HttpSession::Private : public QObject | |||
| return; | |||
| } | |||
|
|
|||
| if(outReq->bytesAvailable() > 0) | |||
| if(state == Proxying) | |||
There was a problem hiding this comment.
this section is simply an indentation (and assertion of the state value)
jkarneges
commented
Sep 5, 2024
| // apply ProxyContent filters of all channels | ||
| QStringList allFilters; | ||
| foreach(const Instruct::Channel &c, instruct.channels) | ||
| if(state == Proxying) |
There was a problem hiding this comment.
another indentation based on state value
jkarneges
commented
Sep 5, 2024
|
|
||
| log_debug("httpsession: failed to retrieve next link"); | ||
| if(state == Proxying) |
There was a problem hiding this comment.
another indentation based on state value
deg4uss3r
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the next link handling in
HttpSessionto make it reusable for other things in the future. It should not introduce any change in behavior. Someif(state == Proxying)conditionals are added in places wherestateis known/assumed to already be of that value.