Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Pharo Exercism track to Pharo 10 #537

Merged
merged 7 commits into from
Apr 25, 2022
Merged

Upgrade Pharo Exercism track to Pharo 10 #537

merged 7 commits into from
Apr 25, 2022

Conversation

Bajger
Copy link
Contributor

@Bajger Bajger commented Apr 20, 2022

@Bajger
Copy link
Contributor Author

Bajger commented Apr 20, 2022

@glennj: Please review, I've updated Pharo track to use latest stable version P10. Unit tests are passing & I've tried manually fetch-publish exercise cycle.

glennj
glennj reviewed Apr 20, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
glennj
glennj approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@glennj glennj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for doing this!

@Bajger
Copy link
Contributor Author

Bajger commented Apr 24, 2022

@glennj : Hi Glenn, can you trigger CI action workflow? I'm not sure, why it wasn't triggered by my last commit.

@Bajger Bajger requested a review from glennj April 24, 2022 07:52
@Bajger
Copy link
Contributor Author

Bajger commented Apr 24, 2022

I see now, CI failed on line 16. Sorry for confusion. I'd need to fix it...

@Bajger
Copy link
Contributor Author

Bajger commented Apr 25, 2022 •
edited
Loading

@glennj : Should be ok now. Added backward compatibility builds up to P8. P7 remains unsupported for now (due to problem in different project that is being loaded in Pharo track). All unit tests are passing, Please review and PR can be merged.

@glennj glennj added the x:size/medium Medium amount of work label Apr 25, 2022
@glennj glennj merged commit f0055f2 into exercism:main Apr 25, 2022
@glennj
Copy link
Contributor

glennj commented Apr 25, 2022

Thanks again @Bajger

@Bajger Bajger deleted the 536-upgrade-to-Pharo10 branch April 26, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennj glennj glennj approved these changes

Assignees
No one assigned
Labels
x:size/medium Medium amount of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adopt Pharo track to use latest stable release (Pharo 10)
2 participants
@Bajger @glennj