Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Changeset: Refactor to improve API, and other cleanups #5233

Draft
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

rhansen
Copy link
Member

@rhansen rhansen commented Oct 17, 2021

DO NOT MERGE: This will be split into multiple smaller pull requests to make things easier to review.

The code in Changeset.js had lots of readability problems so I spent some time trying to clean it up. There shouldn't be any behavior change.

cc @webzwo0i

@webzwo0i
Copy link
Member

webzwo0i commented Nov 9, 2021

Sorry for the late response! This is great work.

Should I cherry-pick some of the commits into new PRs or should I write my comments here? Might get messy fast...

I think having #5267 would be really useful here

@rhansen
Copy link
Member Author

rhansen commented Nov 10, 2021

@webzwo0i I'm going to split this PR into multiple easier-to-digest PRs. #5268 is the first of many. My preference would be to comment on those individual PRs instead of here.

I think having #5267 would be really useful here

Agreed, though I don't think it should block this work.

@rhansen rhansen changed the title Changeset: Refactor to improve API, and other cleanups WIP: Changeset: Refactor to improve API, and other cleanups Nov 10, 2021
@rhansen rhansen force-pushed the rhansen-changeset branch 3 times, most recently from cbf0873 to d7ac033 Compare November 14, 2021 09:33
@rhansen rhansen force-pushed the rhansen-changeset branch 3 times, most recently from 6b7d14a to 12800f6 Compare November 22, 2021 04:03
@rhansen rhansen force-pushed the rhansen-changeset branch 3 times, most recently from 3c19543 to 27d0e11 Compare November 29, 2021 09:50
@stale
Copy link

stale bot commented Apr 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Wont Fix these things, no hate. label Apr 25, 2022
@stale stale bot closed this May 2, 2022
@rhansen rhansen reopened this May 6, 2022
@stale stale bot removed the wontfix Wont Fix these things, no hate. label May 6, 2022
@stale
Copy link

stale bot commented Jul 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Wont Fix these things, no hate. label Jul 10, 2022
@rhansen rhansen removed the wontfix Wont Fix these things, no hate. label Jul 16, 2022
@github-actions github-actions bot added the Stale No recent activity label Jun 23, 2023
@github-actions github-actions bot removed the Stale No recent activity label Jun 27, 2023
@github-actions github-actions bot added the Stale No recent activity label Dec 10, 2023
@github-actions github-actions bot removed the Stale No recent activity label Dec 20, 2023
@github-actions github-actions bot added the Stale No recent activity label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants