Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: standardize npm script names #60

Merged
merged 2 commits into from
Aug 2, 2023
Merged

chore: standardize npm script names #60

merged 2 commits into from
Aug 2, 2023

Conversation

snitin315
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

Refers eslint/eslint#14827

What changes did you make? (Give an overview)

This updates the names of the scripts in package.json to be consistent with the new standard.

Is there anything you'd like reviewers to focus on?

We may need to update the release related scripts on Jenkins before merging this PR.

package.json Outdated
Comment on lines 16 to 20
"release:generate:latest": "eslint-generate-release",
"release:generate:alpha": "eslint-generate-prerelease alpha",
"release:generate:beta": "eslint-generate-prerelease beta",
"release:generate:rc": "eslint-generate-prerelease rc",
"release:publish": "eslint-publish-release",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These commands don't seem to work, for example:

> [email protected] release:generate:latest
> eslint-generate-release

'eslint-generate-release' is not recognized as an internal or external command,
operable program or batch file.

I did npm install but that doesn't seem to handle bin from the package itself.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we have to run the local file because we are releasing the tool in question. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did npm install but that doesn't seem to handle bin from the package itself.

I think you will need to run the npm link command as well. But I'll revert it to the old behavior.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit a453432 into main Aug 2, 2023
7 checks passed
@mdjermanovic mdjermanovic deleted the update-scripts branch August 2, 2023 11:31
@mdjermanovic
Copy link
Member

We may need to update the release related scripts on Jenkins before merging this PR.

Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants