feat: proposals for implementing msg batching to resources #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terry-xiaoyu
force-pushed
the
msg-cache-for-resources
branch
2 times, most recently
from
3632a39
to
458cc3b
Compare
terry-xiaoyu
force-pushed
the
msg-cache-for-resources
branch
from
458cc3b
to
295304b
Compare
qzhuyan
reviewed
Jul 13, 2022
|
|
||
| We prefer the `replayq`, mainly because in this feature messages are always added and accessed in a queue, we never access data by primary keys like a KV database. This is exactly the applicable scenario of `replayq`. The data files will be stored in the specified directory of the local file system, which is very simple. | ||
|
|
||
| The `replayq` was added to the Erlang Kafka driver in 2018, it has experienced several emqx versions and has been proved to be very stable. |
There was a problem hiding this comment.
replayq has its limitations, we may list them here.
There was a problem hiding this comment.
What limitations does it have?
terry-xiaoyu
force-pushed
the
msg-cache-for-resources
branch
from
726f0d6
to
58fc11d
Compare
terry-xiaoyu
changed the title
thalesmg
reviewed
Nov 28, 2022
Comment on lines
+130
to
+131
| - **query_mode**: if set to true, the caller of `emqx_resource:query/3` will be blocked until | ||
| the driver returns or timeouts; if set to false, the `emqx_resource:query/3` returns immediately. |
There was a problem hiding this comment.
Suggested change
| - **query_mode**: if set to true, the caller of `emqx_resource:query/3` will be blocked until | |
| the driver returns or timeouts; if set to false, the `emqx_resource:query/3` returns immediately. | |
| - **query_mode**: if set to sync, the caller of `emqx_resource:query/3` will be blocked until | |
| the driver returns or timeouts; if set to async, the `emqx_resource:query/3` returns immediately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.