Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move createBinding to Binding.fs since it isn't used anywhere else #506

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marner2
Copy link
Collaborator

@marner2 marner2 commented Aug 6, 2022

Ready to merge.

Conflicts with #512 because the createBinding function that got moved gets modified there.

I ran into an issue where the system didn't like having the Name field mentioned first, since it's common with the coming BindingT.Name. Since they differ at Data and DataT records, it made sense to just mention those first. Also moved to Binding.fs since it wasn't needed in that other file.

@marner2 marner2 marked this pull request as draft August 17, 2022 13:10
@marner2 marner2 force-pushed the feature/improve_interop branch 3 times, most recently from 1d6f09c to 8393249 Compare September 9, 2022 01:04
@marner2 marner2 force-pushed the feature/improve_interop branch 2 times, most recently from 3a6d06b to dd0904f Compare September 16, 2022 16:55
@marner2 marner2 mentioned this pull request Sep 16, 2022
41 tasks
@marner2 marner2 force-pushed the feature/improve_interop branch 2 times, most recently from cefd0a3 to 1b664e9 Compare October 3, 2022 17:01
@marner2 marner2 marked this pull request as ready for review October 3, 2022 17:02
@marner2 marner2 changed the title Improve interop by reordering records Move createBinding to Binding.fs since it isn't used anywhere else Oct 3, 2022
@marner2 marner2 marked this pull request as draft March 28, 2023 19:37
@LyndonGingerich
Copy link
Contributor

Since this conflicts with #512, which was combined into #508, I'm guessing this conflicts with #508 now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants