Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(formula): ref range move #3488

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Sep 19, 2024

优化:

  • 抽离公式更新 ref range 偏移参数和偏移范围函数到工具方法,和 defined name 公用

功能:

  • defined name 适配 ref range 更新

修复:

如何测试?

  1. defined name 更新:测试插入行、插入列、删除 sheet 等等对 defined name 的影响
  2. defined name 跳转到所在 sheet 如果已经被隐藏,则先触发显示 sheet (参考 sheet)(注意与超链接跳转 defined name 不同)

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 19, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 19, 2024

Playwright test results

passed  4 passed

Details

stats  4 tests across 2 suites
duration  1 minute, 23 seconds
commit  a036a1e
info  For more information, see full report

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 66.01562% with 174 lines in your changes missing coverage. Please review.

Project coverage is 30.79%. Comparing base (7c66482) to head (a036a1e).
Report is 8 commits behind head on dev.

Files with missing lines Patch % Lines
.../src/controllers/defined-name-update.controller.ts 0.00% 81 Missing ⚠️
...ts-formula/src/controllers/utils/ref-range-move.ts 71.25% 69 Missing ⚠️
...gine-formula/src/services/defined-names.service.ts 6.66% 14 Missing ⚠️
...formula/src/controllers/utils/ref-range-formula.ts 80.76% 5 Missing ⚠️
...ets-hyper-link-ui/src/services/resolver.service.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3488      +/-   ##
==========================================
+ Coverage   30.76%   30.79%   +0.03%     
==========================================
  Files        2156     2161       +5     
  Lines      113129   113269     +140     
  Branches    24796    24844      +48     
==========================================
+ Hits        34799    34883      +84     
- Misses      78330    78386      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant