Cleanup rest of string.Compare[Ordinal] equality checks and replace it with string.Equals

[h3xds1nz]

Description

Finishes up all the easily replaceable string.Compare method uses that are used strictly for equality. The only leftovers shall be now covered in my other PRs where I don't wanna create conflicts for each one of them.

Difference in the last character

Method	Mean [ns]	Error [ns]	StdDev [ns]	Code Size [B]	Allocated [B]
Original	36.525 ns	0.7577 ns	0.7781 ns	446 B	-
PR_EDIT	4.873 ns	0.0175 ns	0.0155 ns	467 B	-

Difference in 5th character

Method	Mean [ns]	Error [ns]	StdDev [ns]	Code Size [B]	Allocated [B]
Original	4.627 ns	0.0493 ns	0.0437 ns	446 B	-
PR_EDIT	2.668 ns	0.0138 ns	0.0129 ns	467 B	-

Benchmark source strings

//First invocation (last char is different)
return string.Compare("someveryrandomstringthatwillonlydifferintheveryendwewillmakesureofit0",
"someveryrandomstringthatwillonlydifferintheveryendwewillmakesureofit1", 
StringComparison.OrdinalIgnoreCase) == 0;
return string.Equals("someveryrandomstringthatwillonlydifferintheveryendwewillmakesureofit0",
"someveryrandomstringthatwillonlydifferintheveryendwewillmakesureofit1", 
StringComparison.OrdinalIgnoreCase);

//Second invocation (5th char is different)
return string.Compare("some0veryrandomstringthatwillonlydifferintheveryendwewillmakesureofit0",
"some1veryrandomstringthatwillonlydifferintheveryendwewillmakesureofit1", 
StringComparison.OrdinalIgnoreCase) == 0;
return string.Equals("some0veryrandomstringthatwillonlydifferintheveryendwewillmakesureofit0",
"some1veryrandomstringthatwillonlydifferintheveryendwewillmakesureofit1", 
StringComparison.OrdinalIgnoreCase);

Customer Impact

Improved performance.

Regression

No.

Testing

Local build.

Risk

Very low, those are IDE swaps besides three manual edits.

Microsoft Reviewers: Open in CodeFlow