Make sure Git pre-commit hook directory exists before copying script #9678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the repo for the first time, installing the WPF Git pre-commit hook will fail because it tries to Copy-Item the script into a directory that does not exist. This change adds a check for the directory and if it does not exist, will create it.
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
the
PR
lewing
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When building the repo for the first time, installing the WPF Git pre-commit hook will fail because it tries to Copy-Item the script into a directory that does not exist.
This change adds a check for the directory and if it does not exist, will create it.
Customer Impact
They'll continue to not have the pre-commit hook installed.
Regression
Doesn't appear to be.
Testing
Just build off a fresh repo and notice the prehook gets installed.
Risk
None that I know of.
Microsoft Reviewers: Open in CodeFlow