Make the toolbar menu items support the support space key. #11520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11520 +/- ##
===================================================
+ Coverage 74.39859% 74.56175% +0.16316%
===================================================
Files 3032 3041 +9
Lines 628149 629780 +1631
Branches 46828 46845 +17
===================================================
+ Hits 467334 469575 +2241
+ Misses 157465 156843 -622
- Partials 3350 3362 +12
Flags with carried forward coverage won't be shown. Click here to find out more. |
SimonZhao888
requested review from
Tanya-Solyanik,
lonitra,
ricardobossan,
LeafShi1 and
Epica3055
SimonZhao888
changed the title
elachlan
added
the
waiting-review
|
All LGTM |
LeafShi1
reviewed
Jul 5, 2024
src/System.Windows.Forms/src/System/Windows/Forms/Controls/ToolStrips/ToolStripMenuItem.cs
Outdated
Show resolved
Hide resolved
lonitra
reviewed
Jul 11, 2024
src/System.Windows.Forms/src/System/Windows/Forms/Controls/ToolStrips/ToolStripDropDown.cs
Show resolved
Hide resolved
lonitra
added
📭 waiting-author-feedback
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
lonitra
added
the
ready-to-merge
dotnet-policy-service
bot
removed
the
ready-to-merge
| @@ -1253,6 +1253,7 @@ protected override void OnItemClicked(ToolStripItemClickedEventArgs e) | |||
| || !(dismissingItem.HasDropDownItems)) | |||
| { // clicking on a item w/dropdown does not dismiss window | |||
| Close(ToolStripDropDownCloseReason.ItemClicked); | |||
| SelectPreviousToolStrip(); | |||
There was a problem hiding this comment.
@SimonZhao888 - Perhaps this line requires additional checks, sometime focus should not return to the owner item. See #11909
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11449
Proposed changes
Customer Impact
Regression?
Risk
-Minimal
Screenshots
Before
After
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow