Fix: Allow double clicks to propagate. #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @fsbraun , it works well, When are you merging this pr? |
|
@vipulnarang95 I was hoping for your feedback if the PR solves your issue. You can install and test it using Once I get your confirmation, I can have it reviewed, merged, and released. |
|
Hi @fsbraun , I confirm it is working fine |
|
@fsbraun Can you also release this? |
|
@vipulnarang95 Yepp, out now. |
|
I am not able to see on divio cloud? Is there a separate release for this? |
|
I publish on pypi. Maybe it only takes some time to run through on divio cloud? You might have to ask them. |
|
Which version it is? 5.1.6? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #675
Since the introduction of inline editing, double-clicks had been swallowed. Now they propagate.
@vipulnarang95 Can you please confirm this PR fixes your issue?