-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nrfxlib to 2.4.2 #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tdittr
commented
Sep 5, 2023
- Update nrfxlib
- Remove unnecessary FFI
- Adapt IPC handling to updated nrfxlib
The changes needed do not seem to be documented in the changelog by NRF. Luckily nrfx had basically the changes that were needed to fix the IPC. So links to the relevant code parts were added for if fixes in the future become necessary.
tdittr
commented
Sep 5, 2023
@tdittr Ok, I've let the CI run and it breaks on some formatting. |
diondokter
reviewed
Sep 6, 2023
Yes I wanted to keep it a draft until we can remove the |
This should make this crate ready for a new release.
Cool, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.