added jsonb_insert
#4257
Open
added jsonb_insert
#4257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aznszn
force-pushed
the
add_jsonb_insert
branch
from
07f37bc
to
2a9e3df
Compare
aznszn
force-pushed
the
add_jsonb_insert
branch
from
2a9e3df
to
c2d9b2c
Compare
weiznich
requested changes
Sep 19, 2024
| /// # Ok(()) | ||
| /// # } | ||
| /// ``` | ||
| fn jsonb_insert<J: JsonbOrNullableJsonb + SingleValue, P: TextArrayOrNullableTextArray + CombinedNullableValue<J, Jsonb>>(target: J, path: P, value: J) -> P::Out; |
There was a problem hiding this comment.
We need to have separate generic types for the first and last argument here to allow using different types in these places. That allows us to use a column in one place and an expression in another place while calling this function. That means we won't be able to use CombineNullableValue as it is, we might need another helper trait there or some more experimentation how to combine three or four values with the existing trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the
jsonb_insertfunction under #4216.