Feature fun #2

dev-oiram · 2021-10-04T00:41:22Z

Introduction

In this update it has been created a more like Game enviroment to make it fun 🥇

Features

The ball is finally a circle
Added new Game Music to feel adrenaline in the moment you start playing
Added sound effects when the ball bounces and when players score a point.
When ball bounce off pallet the speed increase but also the players speed increase to get more stamina.
Added new Game background instead of the empty white screen.
And also moved players more to the center of the screen to leave the goals space visible

VideoDemo

Demo.mp4

create new RoundBall class node and add radius propertie

Remove the square ball and increase speed of players paddle

Add Net Node Class, create textsize varibles for main and second

Add Sound class and implement Game Music

Add bounce and point-score sound effects

Add background, remove body margin and adjust some of objects colors

When players hit the ball their speed also increase

demiculus · 2021-10-04T18:10:19Z

public/js/modules/start.js

@@ -90,11 +100,13 @@ app.onUpdate = function(time){

 app.pause = function(){
    if(state == 'GAME'){
+        music.pause() // Pause Game Music


music.pause() isn't descriptive enough so you added // Pause Game Music to make sure the code reader understands right? :D

Hi, yes I define the "music" object and added some comments when I invoke the methods

demiculus · 2021-10-04T18:13:04Z

public/js/modules/start.js

        }

        if(keyName == ' '){
-            if(state == 'GAME' || state == 'PAUSE')
+            if(state == 'GAME' || state == 'PAUSE'){


a typo and the game breaks
maybe you shouldn't use strings huh?

Do you know how to use enum?

Oh I see, I haven´t use enum before but I can change it and not use strings

demiculus · 2021-10-04T18:14:39Z

public/js/modules/module.js

@@ -3,17 +3,17 @@
 class Player {
    constructor(id,app,color,playerNum) {
        this.initialY = app.height/2
-        this.speed = 8
+        this.speed = 10


Ever heard of magic numbers?

You're a true magician putting magic all over the code :D

You´re right, I should create some constants for those values to be easy to track.

demiculus · 2021-10-04T18:21:23Z

Do you have linkedin? If not can you attach your CV or a blurb about your past.
You're missing a lot of simple stuff as I posted above.
I want to see how well you learn before moving forward. Since you've got a lot to learn. Any idea how we should gauge your learning?
Any extra information on top of your linkedin/cv would be beneficial. Like where you are, what you do etc..

dev-oiram · 2021-10-04T19:12:43Z

Do you have linkedin? If not can you attach your CV or a blurb about your past.

You're missing a lot of simple stuff as I posted above.

I want to see how well you learn before moving forward. Since you've got a lot to learn. Any idea how we should gauge your learning?

Any extra information on top of your linkedin/cv would be beneficial. Like where you are, what you do etc..

Hi, I don´t have a linkedin account but I can tell you about myself.

I live in Mexico and I´m 33 years old
I currently work developing web apps for some clients to create and manage their quotations.
Me and a friend created a society call DoCode to present ourselves with the clients to start develope their apps
We use Django framework for the backend and Vue for the frontend
I have spend some time checking game development videos and tutorias and been working with pixijs, phaser and unity

Languages

This are some of the languages I´ve worked as developer
C++
C#
Java
Python
JavaScript
TypeScript

´I have always adapted to the language that is require, is true that I´m missing on some of the good practices on coding and to be really honest this is the first time somene review my code, I´ve always reviewed someone else apps functionality and make some code adjustment because of the deadlines to the clients´

dev-oiram added 7 commits October 3, 2021 13:37

Create new RoundBall

1b13fdb

create new RoundBall class node and add radius propertie

Remove Square Ball

cac9e33

Remove the square ball and increase speed of players paddle

Add Net Node

10e8eb5

Add Net Node Class, create textsize varibles for main and second

Add Sound class

1167937

Add Sound class and implement Game Music

Added sound effects

6856319

Add bounce and point-score sound effects

Add background to the Game

54d6158

Add background, remove body margin and adjust some of objects colors

Adjust Players speed

246baef

When players hit the ball their speed also increase

dev-oiram requested a review from demiculus October 4, 2021 00:42

demiculus reviewed Oct 4, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature fun #2

Feature fun #2

dev-oiram commented Oct 4, 2021 •

edited

Loading

demiculus Oct 4, 2021 •

edited

Loading

dev-oiram Oct 4, 2021

demiculus Oct 4, 2021 •

edited

Loading

demiculus Oct 4, 2021

dev-oiram Oct 4, 2021

demiculus Oct 4, 2021

dev-oiram Oct 4, 2021

demiculus commented Oct 4, 2021

dev-oiram commented Oct 4, 2021

Feature fun #2

Are you sure you want to change the base?

Feature fun #2

Conversation

dev-oiram commented Oct 4, 2021 • edited Loading

Introduction

Features

VideoDemo

demiculus Oct 4, 2021 • edited Loading

Choose a reason for hiding this comment

dev-oiram Oct 4, 2021

Choose a reason for hiding this comment

demiculus Oct 4, 2021 • edited Loading

Choose a reason for hiding this comment

demiculus Oct 4, 2021

Choose a reason for hiding this comment

dev-oiram Oct 4, 2021

Choose a reason for hiding this comment

demiculus Oct 4, 2021

Choose a reason for hiding this comment

dev-oiram Oct 4, 2021

Choose a reason for hiding this comment

demiculus commented Oct 4, 2021

dev-oiram commented Oct 4, 2021

Languages

dev-oiram commented Oct 4, 2021 •

edited

Loading

demiculus Oct 4, 2021 •

edited

Loading

demiculus Oct 4, 2021 •

edited

Loading