Tidy up creation of VSP clients. #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the second commit changes the error code for invalid vsp arguments from InvalidArgument to Unknown. intentional? |
|
Good catch, not intentional. I'll need to rethink this. |
|
Marking this PR as draft because it has significant overlap with #2428 |
- Remove duplicated param validation. - Fix error messages (some referred to VSP server or ticketbuyer instead of VSP client).
jholdstock
force-pushed
the
attempt2
branch
from
41f8689
to
e79d2e5
Compare
jrick
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing a lot of duplication and boilerplate. Will squash before merge.