Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

udb: Add tests for serializing VSP data. #2254

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Conversation

jholdstock
Copy link
Member

Just adding tests for existing behaviour, no changes to production code.

Copy link
Member

@jrick jrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit

FeeHash: *feeHash,
FeeTxStatus: 123,
VSPHostID: 321,
Host: "a-vsp.com",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use example.com or a subdomain of this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Just adding tests for existing behaviour, no changes to production code.
@jrick jrick merged commit 25c7b34 into decred:master Jun 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants