Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of alias #45

Merged
merged 3 commits into from
Apr 18, 2014
Merged

get rid of alias #45

merged 3 commits into from
Apr 18, 2014

Conversation

deanmalmgren
Copy link
Owner

This is a little redundant given the fact that we have autocomplete incorporated into workflow. This has the added benefit of making the internal code a bit simpler.

@deanmalmgren
Copy link
Owner

@ahwolf before we get rid of aliases, are you using them at all?

@ahwolf
Copy link

ahwolf commented Apr 7, 2014

Nope.
On Apr 7, 2014 1:09 PM, "Dean Malmgren" [email protected] wrote:

@ahwolf https://github.com/ahwolf before we get rid of aliases, are you
using them at all?

Reply to this email directly or view it on GitHubhttps://github.com//issues/45#issuecomment-39763543
.

@deanmalmgren
Copy link
Owner

I started to get rid of alias, but before I merge this, I'd like to see what happens with #11, which has a pretty compelling use case for an alias. This is also described in the design specification. If anyone has any workarounds for these...

@deanmalmgren
Copy link
Owner

In digging into the regexp implementation in issue #11 a bit, I'm realizing that getting rid in favor of tags as described in #45 would be pretty nice. When Tasks are dynamically added to the TaskGraph that match a particular regular expression, it'd be nice for those tasks to be able to re-use the tags in their commands definition. Then its explicit that these aliases are not unique.

@deanmalmgren deanmalmgren merged commit f2ed3fe into master Apr 18, 2014
@deanmalmgren deanmalmgren deleted the issue-45 branch April 18, 2014 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants