Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add obsidian canvas support #629

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add obsidian canvas support #629

wants to merge 3 commits into from

Conversation

mohamedsalem401
Copy link
Contributor

For #578
Supported:

  • PDF
  • Youtube embeds
  • Images
  • Text
  • Edges
  • Embedded markdown files

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowershow-ssr-r2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 4:37am

Copy link
Member

@olayway olayway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! There are some minor fixes needed though, like:

  1. Hiding the overflowing content
  2. Hiding # next to headings
  3. Arrows should be ended with arrows, not circles
  4. (Minor) Add links to names of embedded files

image

Also, we need to adjust the main layout so that we can go full width, but let's create a separate issue for that. And another one for zoom/pinch controls.

@saviorand
Copy link

Very impressive!

@rufuspollock
Copy link
Member

@olayway could we merge this? Is it "good enough for now"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants