Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow children in mobile nav #1086

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

homostellaris
Copy link

@homostellaris homostellaris commented Feb 2, 2024

Adds some finishing touches to @olayway's work to
allow the mobile nav to render arbitrary children
which can be useful for things like site-wide
navigation.

Also adds some stories to demonstrate the new
functionality and migrates to the Storybook NextJs 'framework' which allows the Nav component to be
rendered in a story with all the routing
automatically stubbed and taken care of.

Screen.Recording.2024-02-02.at.17.23.55.mov

Copy link

changeset-bot bot commented Feb 2, 2024

⚠️ No Changeset found

Latest commit: 7b38ce1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
portaljs-alan-turing ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2024 8:47am
portaljs-ckan ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2024 8:47am
portaljs-git-example ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2024 8:47am
portaljs-learn ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2024 8:47am
portaljs-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2024 8:47am
site-portaljs ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2024 8:47am

Copy link

vercel bot commented Feb 2, 2024

@homostellaris is attempting to deploy a commit to the Datopian Team on Vercel.

A member of the Team first needs to authorize it.

@homostellaris
Copy link
Author

Accidentally added some reformatting there, will tidy that up shortly

@homostellaris
Copy link
Author

Diff is cleaned up now, looks like I need authorization to pass some checks though?

@homostellaris
Copy link
Author

@Gutts-n sorry to @ you but any idea what I can do to get this merged? Myself and many others would love this to enable mobile site-wide table of contents for Flowershow.

@Gutts-n
Copy link
Contributor

Gutts-n commented Feb 16, 2024

Hello @homostellaris you could request @olayway to make the CR, and your PR doesn't have a changeset, you need to run npx changeset in the main folder of the project and select to be a minor bump with a comment about the functionality implemented, after it you push these changeset's files to your branch and it'll be good to us make the CR and merge.

Screenshot_2024-02-16-20-28-11-965_com.github.android.jpg

Adds some finishing touches to @olayway's work to
allow the mobile nav to render arbitrary children
which can be useful for things like site-wide
navigation.

Also adds some stories to demonstrate the new
functionality and migrates to the Storybook NextJs
'framework' which allows the Nav component to be
rendered in a story with all the routing
automatically stubbed and taken care of.
@homostellaris
Copy link
Author

Thanks @Gutts-n, I've added the changeset, my bad for not reading the contribution docs properly!

@olayway if you could take a look at this would be awesome 🙏

@homostellaris
Copy link
Author

Any way to progress this? Totally understand if this isn't a priority but just to provide honest feedback, I'll have to eventually migrate away from Flowershow if the open source community isn't active 🙏

@olayway olayway self-requested a review August 29, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants