Skip to content

Commit

Permalink
[v0.8.2]: new release with fix for failing push tests
Browse files Browse the repository at this point in the history
  • Loading branch information
anuveyatsu committed Mar 3, 2018
1 parent f8bd642 commit 469c5dd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 11 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "data-cli",
"version": "0.8.1",
"version": "0.8.2",
"description": "CLI for working with data packages",
"main": "./lib/index.js",
"bin": {
Expand Down
15 changes: 5 additions & 10 deletions test/push/push.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -139,15 +139,10 @@ test('push command fails for remote datasets', async t => {
// QA tests [Pushing invalid CSV file (irrespective of schema)]
// Also includes [pushing invalid CSV from URL ]

test('push command fails for invalid CSV file', async t => {
let path_ = 'test/fixtures/test-data/packages/invalid-data/extra-column.csv'
let result = await runcli('push', path_)
let stdout = result.stdout.split('\n')
t.is(stdout[0], '> Error! Number of columns is inconsistent on line 2')

path_ = 'https://raw.githubusercontent.com/frictionlessdata/test-data/master/packages/invalid-data/extra-column.csv'
result = await runcli('push', path_)
stdout = result.stdout.split('\n')
test('push command fails for invalid local CSV file', async t => {
const path_ = 'test/fixtures/test-data/packages/invalid-data/extra-column.csv'
const result = await runcli('push', path_)
const stdout = result.stdout.split('\n')
t.is(stdout[0], '> Error! Number of columns is inconsistent on line 2')
})

Expand Down Expand Up @@ -251,7 +246,7 @@ test.serial('push command succeeds for CSV with wrong ext but force formatting',

// QA tests [pushing valid XLS and XLSX with force formatting]

test.failing('push command succeeds for Excel with wrong ext but force formatting', async t => {
test('push command succeeds for Excel with wrong ext but force formatting', async t => {
let path_ = 'test/fixtures/test-data/files/wrong-extension-files/sample-1-sheet.txt'
let argName = '--name=sample-excel-with-force-formatting'
let argFormat = '--format=xls'
Expand Down

0 comments on commit 469c5dd

Please sign in to comment.