Skip to content

Commit

Permalink
[Update][m]: Feedbacks implemented
Browse files Browse the repository at this point in the history
  • Loading branch information
sneha-sharma12 committed Apr 11, 2024
1 parent ec5770c commit 722d2f8
Show file tree
Hide file tree
Showing 7 changed files with 46 additions and 11 deletions.
18 changes: 17 additions & 1 deletion ckanext/ubdc/assets/css/style.css
Original file line number Diff line number Diff line change
Expand Up @@ -10500,6 +10500,10 @@ h4 small {
line-height: 1.5;
display: flex;
}
.homepage .funding .funded_logo img {
object-fit: contain;
max-width: 11em;
}
.homepage .funding .wrap {
padding-top: 3em;
padding-bottom: 3em;
Expand Down Expand Up @@ -11003,13 +11007,25 @@ h4 small {
font-weight: 300;
}
.site-footer__bottom ul li:last-child::after {
content: "";
content: " ";
margin: 0;
}
.site-footer__bottom .attribution {
padding-top: 20px;
display: flex;
justify-content: space-between;
text-transform: capitalize;
}

.footer_link-block-head {
color: #09090b;
margin-top: 0;
margin-bottom: 1.5vw;
font-family: Inter, sans-serif;
font-size: 1em;
font-weight: 600;
line-height: 1.5;
text-decoration: none;
}

@media (max-width: 768px) {
Expand Down
4 changes: 4 additions & 0 deletions ckanext/ubdc/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ def get_gtm_id():
"""Return the Google Tag Manager ID."""
return tk.config.get("ckanext.ubdc.gtm_id", "")

def get_newsletter_link():
"""Return the Newsletter Link."""
return tk.config.get("ckanext.ubdc.newsletter_link", "")


def get_cookie_control_config():
cookie_control_config = {}
Expand Down
1 change: 1 addition & 0 deletions ckanext/ubdc/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ def get_helpers(self):
"get_cookie_control_config": helpers.get_cookie_control_config,
"get_field_to_question": helpers.get_field_to_question,
"get_data_providers": helpers.get_data_providers,
"get_newsletter_link": helpers.get_newsletter_link
}

# IValidators
Expand Down
14 changes: 12 additions & 2 deletions ckanext/ubdc/public/base/scss/_footer.scss
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@
font-weight: 300;
}
&:last-child::after {
content: "";
content: " ";
margin: 0;
}
}
Expand All @@ -146,10 +146,20 @@
padding-top: 20px;
display: flex;
justify-content: space-between;
text-transform: capitalize;
}
}
}

.footer_link-block-head {
color: #09090b;
margin-top: 0;
margin-bottom: 1.5vw;
font-family: Inter, sans-serif;
font-size: 1em;
font-weight: 600;
line-height: 1.5;
text-decoration: none;
}
@media (max-width: $screen-sm-min) {
.site-footer {
all: unset;
Expand Down
4 changes: 4 additions & 0 deletions ckanext/ubdc/public/base/scss/_homepage.scss
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,10 @@
font-size: 1em;
line-height: 1.5;
display: flex;
img {
object-fit: contain;
max-width: 11em;
}
}
.wrap {
padding-top: 3em;
Expand Down
14 changes: 7 additions & 7 deletions ckanext/ubdc/templates/footer.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
title="{{ g.site_title }}" /></a>
</div>
<div class="site-footer__col-2">
<h4>Data</h4>
<h4 class="footer_link-block-head">Data</h4>
<ul class="footer__list">
<li>
<a href="https://ubdc.ac.uk/data-services" target="_blank">Data Services</a>
Expand All @@ -19,7 +19,7 @@ <h4>Data</h4>
</ul>
</div>
<div class="site-footer__col-2">
<h4>Research</h4>
<h4 class="footer_link-block-head">Research</h4>
<ul class="footer__list">
<li>
<a href="https://www.ubdc.ac.uk/research-themes" target="_blank">Research Themes</a>
Expand All @@ -33,7 +33,7 @@ <h4>Research</h4>
</ul>
</div>
<div class="site-footer__col-2">
<h4>Education &amp; Events</h4>
<h4 class="footer_link-block-head">Education &amp; Events</h4>
<ul class="footer__list">
<li>
<a href="https://www.ubdc.ac.uk/education" target="_blank">MSc and PhD</a>
Expand All @@ -44,18 +44,18 @@ <h4>Education &amp; Events</h4>
</ul>
</div>
<div class="site-footer__col-2">
<h4>Impact</h4>
<h4 class="footer_link-block-head">Impact</h4>
<ul class="footer__list">
<li>
<a href="https://www.ubdc.ac.uk/news" target="_blank">News</a>
<a href="https://www.ubdc.ac.uk/news" class="footer_link-block-head" target="_blank">News</a>
</li>
<li>
<a href="https://www.ubdc.ac.uk/events" target="_blank">Events</a>
<a href="https://www.ubdc.ac.uk/events" class="footer_link-block-head" target="_blank">Events</a>
</li>
</ul>
</div>
<div class="site-footer__col-2">
<h4>About UBDC</h4>
<h4 class="footer_link-block-head">About UBDC</h4>
<ul class="footer__list">
<li>
<a href="mailto: [email protected]" target="_blank">Contact Us</a>
Expand Down
2 changes: 1 addition & 1 deletion ckanext/ubdc/templates/home/snippets/newsletter.html
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ <h2 class="head-h2">UBDC Newsletter</h2>
</p>
</div>
<div class="">
<a class="btn btn-primary btn-newsletter" href="https://ubdc.ac.uk/subscribe"
<a class="btn btn-primary btn-newsletter" href="{{h.get_newsletter_link()}}"
>SIGN UP</a
>
</div>
Expand Down

0 comments on commit 722d2f8

Please sign in to comment.