Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text clarifications and minor formatting fixes #377

Merged
merged 6 commits into from
Sep 11, 2024
Merged

Conversation

adamancer
Copy link
Contributor

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

Clarifies installation, instructions for opening a database file, and SELECT behavior and fixes list formatting in a proposed lesson.

If any relevant discussions have taken place elsewhere, please provide links to these.

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at [email protected].

Copy link

github-actions bot commented Aug 8, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/sql-ecology-lesson/compare/md-outputs..md-outputs-PR-377

The following changes were observed in the rendered markdown documents:

 00-sql-introduction.md  |  2 +-
 01-sql-basic-queries.md | 14 ++++++++------
 discuss.md              | 24 +++++++++++++-----------
 md5sum.txt              |  8 ++++----
 setup.md                |  1 +
 5 files changed, 27 insertions(+), 22 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-09-11 07:02:20 +0000

github-actions bot pushed a commit that referenced this pull request Aug 8, 2024
learners/discuss.md Outdated Show resolved Hide resolved
learners/discuss.md Outdated Show resolved Hide resolved
github-actions bot pushed a commit that referenced this pull request Sep 11, 2024
@jd-foster jd-foster merged commit 47ec0f2 into main Sep 11, 2024
3 checks passed
@jd-foster jd-foster deleted the contrib/adamancer branch September 11, 2024 07:03
@jd-foster
Copy link
Contributor

Thanks for your work here @adamancer

github-actions bot pushed a commit that referenced this pull request Sep 11, 2024
Auto-generated via {sandpaper}
Source  : 47ec0f2
Branch  : main
Author  : Adam Mansur <[email protected]>
Time    : 2024-09-11 07:03:34 +0000
Message : Text clarifications and minor formatting fixes (#377)

* Specifies preferred macOS install option (#375)

* Fixed formatting in proposed design lesson (#374)

* Clarified how calculations are returned by SELECT (#372)

* Clarified Open Database instruction (#370)

* Fix typo in learners/discuss.md

* Fix formatting in learners/discuss.md

---------

Co-authored-by: James Foster <[email protected]>
github-actions bot pushed a commit that referenced this pull request Sep 11, 2024
Auto-generated via {sandpaper}
Source  : 92a7d28
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-09-11 07:04:23 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47ec0f2
Branch  : main
Author  : Adam Mansur <[email protected]>
Time    : 2024-09-11 07:03:34 +0000
Message : Text clarifications and minor formatting fixes (#377)

* Specifies preferred macOS install option (#375)

* Fixed formatting in proposed design lesson (#374)

* Clarified how calculations are returned by SELECT (#372)

* Clarified Open Database instruction (#370)

* Fix typo in learners/discuss.md

* Fix formatting in learners/discuss.md

---------

Co-authored-by: James Foster <[email protected]>
github-actions bot pushed a commit that referenced this pull request Sep 17, 2024
Auto-generated via {sandpaper}
Source  : 92a7d28
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-09-11 07:04:23 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47ec0f2
Branch  : main
Author  : Adam Mansur <[email protected]>
Time    : 2024-09-11 07:03:34 +0000
Message : Text clarifications and minor formatting fixes (#377)

* Specifies preferred macOS install option (#375)

* Fixed formatting in proposed design lesson (#374)

* Clarified how calculations are returned by SELECT (#372)

* Clarified Open Database instruction (#370)

* Fix typo in learners/discuss.md

* Fix formatting in learners/discuss.md

---------

Co-authored-by: James Foster <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants