Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP attempt at using the FS beforehand the API for github #991

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

orta
Copy link
Member

@orta orta commented Feb 11, 2020

I don't have time to make it green, but maybe this could work

Base automatically changed from master to main February 4, 2021 08:31
Copy link
Member

@fbartho fbartho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the "purpose" of this change? Is it just a flakiness/performance optimization? or is it something more?

No objections conceptually, so once it's green I'm happy to re-review for you!


exec(call, (err, stdout, _stderr) => {
if (err) {
console.error(`Could not get the git HEAD for the current path]`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.error(`Could not get the git HEAD for the current path]`)
console.error(`Could not get the git HEAD for the current path`)


export const localGetHeadSHA = () =>
new Promise<string>(done => {
const call = `git rev-parse HEAD"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const call = `git rev-parse HEAD"`
const call = `git rev-parse HEAD`

This typo looks like it might be the first level of why the PR was red 🟥

Comment on lines +62 to +97
// expect(rangesOfDifferBetweenTwoStrings(src, target)).toMatchInlineSnapshot(`
// Array [
// Object {
// "length": 1,
// "start": 6,
// },
// ]
// `)

// const multilineInput = `
// ↓
// (↓
// ····<div>↓
// ······text↓
// ····</div>↓
// )
// `
// const multilineOutput = `
// ↓
// (↓
// ····<div>↓
// ········text↓
// ······</div>↓
// )`
// expect(rangesOfDifferBetweenTwoStrings(multilineInput, multilineOutput)).toMatchInlineSnapshot(`
// Array [
// Object {
// "length": 8,
// "start": 22,
// },
// Object {
// "length": 10,
// "start": 32,
// },
// ]
// `)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// expect(rangesOfDifferBetweenTwoStrings(src, target)).toMatchInlineSnapshot(`
// Array [
// Object {
// "length": 1,
// "start": 6,
// },
// ]
// `)
// const multilineInput = `
// ↓
// (↓
// ····<div>↓
// ······text↓
// ····</div>↓
// )
// `
// const multilineOutput = `
// ↓
// (↓
// ····<div>↓
// ········text↓
// ······</div>↓
// )`
// expect(rangesOfDifferBetweenTwoStrings(multilineInput, multilineOutput)).toMatchInlineSnapshot(`
// Array [
// Object {
// "length": 8,
// "start": 22,
// },
// Object {
// "length": 10,
// "start": 32,
// },
// ]
// `)

Not sure if this was a copy-pasted test file, or if you actually want these tests to work?

@orta
Copy link
Member Author

orta commented Jan 7, 2022

Perf, people check huge amounts of files and that can hit the GH API limits

@fbartho fbartho mentioned this pull request Jan 7, 2022
@sanex3339
Copy link

sanex3339 commented Apr 29, 2022

Can you finish this, please?

@Jimimaku
Copy link

Jimimaku commented Nov 21, 2022

Können Sie das bitte beenden?

@orta
Copy link
Member Author

orta commented Nov 21, 2022

It's OSS people, feel free to take over the PR instead of asking for folks to do volunteer work for you 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants