Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GitLab CI support for MRs from forks #978

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

carburo
Copy link

@carburo carburo commented Jan 24, 2020

Current GitLab CI provider gets the repoSlug from the environment variable CI_PROJECT_PATH, which by default points to the project from where the MR is created. This works fine for MRs coming from the same project, but not for MRs coming from forks. Starting on Gitlab 11.6 there is CI_MERGE_REQUEST_PROJECT_PATH environment variable that works for both cases.

@orta
Copy link
Member

orta commented Jan 24, 2020

Great - would be good to get a test for this, but other than that - looks perfect. Thanks!

@carburo
Copy link
Author

carburo commented Jan 24, 2020

Yes, sorry about that! I'll add a test. Thank you!

Base automatically changed from master to main February 4, 2021 08:31
@Jimimaku

This comment was marked as spam.

@Jimimaku

This comment was marked as spam.

@Jimimaku

This comment was marked as spam.

@glensc
Copy link
Contributor

glensc commented Feb 7, 2023

Merge without tests then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants